Refactor div to resolve linter error –– about-card-partners.html #5344
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
bot
added
good first issue
|
Thanks @Vinny02 and @adrianang for the feedback on my previous PR! |
|
Availability 8/29 3p-5p PST |
roslynwythe
requested review from
mshirk2,
macho-catt and
MattChau01
and removed request for
macho-catt
|
Review ETA: 5pm 8/30 |
|
Availability: weekday evening |
There was a problem hiding this comment.
@homeroochoa47 great job on your 'good first issue'. You made the correct code change, which checks out fine in the browser, and you setup the branches correctly and described your work in the PR. Thank you!
There was a problem hiding this comment.
Branching is set up correctly, the issue is linked, PR describes the solution well, and the changes to the quotes have been made. Great work @homeroochoa47!
There was a problem hiding this comment.
- The branch is going into the correct branch
gh-pages. ✅ - The original issue Refactor HTML to resolve linter error: _includes/about-page/about-card-partners.html #5287 was properly referenced. ✅
- The specified class on line 1 was correctly adjusted to double quotes as specified. ✅
Good fix @homeroochoa47 !
There was a problem hiding this comment.
Hey @homeroochoa47 Great job on your first issue- Branches are correct, the orig. issue is linked, the description covers the what and why, and your code is clean and changes only what needs to be changed.
Thanks for your work!
Fixes #5287
What changes did you make?
Why did you make the changes (we will use this info to test)?
-Resolves the linter error "Value of attribute [class] must be in double quotes"
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)